This bmw e36 fog light repair describes my process of changing the bulbs and then diagnosing the problem with the assemblies. 

Initially I planned on changing the fog light bulbs and assemblies on my brothers 1995 BMW 318i, however the fog lights did not work after I changed them.

First I checked the two fog light fuses and then checked the relay, afterwards I tested the fog light button, and examined the wiring. I finally took another look at the assembly connector and noticed that the new assemblies had abysmal connectors. 

After I changed the connectors on the two new fog light assemblies, they worked perfectly.

BMW E36 Fog Light Assemblies are quite easy to work on and repair. They are extremely easy to remove, as they have a lever that can be pressed and then the assemblies are released from the bracket.